This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Documentation: document image lifecycle and implementation. #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --------------------- | ||
| ``` | ||
|
|
||
| Currently rkt implements the appc spec, in future additional specs like (OCI) may be implemented keeping the same logic but chaning the implementations. |
|
I've spotted some typos, but I guess @joshix may have additional inputs to reword some of these sentences. Great to have this information written down, the decoupling part at the bottom was not clear to me before. |
sgotti
force-pushed
the
image_lifecycle_architecture
branch
from
903dc9c
to
0e1c6ed
Compare
|
@lucab Thanks. Obviously there are better way to write the sentences 😄 The real intent is to explain how and why it works in this way, just to gather additional thoughts, better ideas and to have a starting point for future work on implementing the oci image spec. |
sgotti
force-pushed
the
image_lifecycle_architecture
branch
2 times, most recently
from
d0104fa
to
15ea291
Compare
This was referenced Jul 22, 2016
|
@joshix ping :-) |
sgotti
force-pushed
the
image_lifecycle_architecture
branch
from
15ea291
to
0e2664d
Compare
|
ack, looking, sorry about the delay. Will review today. |
|
@joshix thanks, no problem. I was just going through milestoned PRs as tomorrow is release day. |
|
|
||
| ### Image lifecycle | ||
|
|
||
| rkt commands like prepare and run, as a first step, needs to retrieve all the required images provided in the command line and prepare the stage2 directories with the application contents. |
There was a problem hiding this comment.
s/needs/need/
s/required images provided/images requested/
Document the image lifecycle phases, their logic and explain the rkt implementations.
sgotti
force-pushed
the
image_lifecycle_architecture
branch
from
0e2664d
to
864f661
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the image lifecycle phases, their logic and explain the rkt implementations.