Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

stage1: don't suppress error output #2111

Merged
merged 3 commits into from
Feb 4, 2016

Conversation

blixtra
Copy link
Collaborator

@blixtra blixtra commented Feb 4, 2016

Closes #2038

@alban
Copy link
Member

alban commented Feb 4, 2016

  • changelog
  • tests

@blixtra blixtra force-pushed the ckuehl/stage1-dont-supress-errors branch from ab0d1ad to a701f85 Compare February 4, 2016 11:17
@alban alban mentioned this pull request Feb 4, 2016
10 tasks
@@ -140,7 +141,7 @@ func init() {
flag.StringVar(&podPid, "pid", "", "podPID")
flag.StringVar(&appName, "appname", "", "application to use")

log = rktlog.New(os.Stderr, "kvm", false)
log, diag, _ = rktlog.NewLogSet("kvm", false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO for later (added in #1131):

If rktlog.NewLogSet and exec.LookPath("ssh") are moved in main(), it will not need to call SetDebug() manually.

@blixtra blixtra force-pushed the ckuehl/stage1-dont-supress-errors branch from b4475a1 to 9ac9bb8 Compare February 4, 2016 14:36
@blixtra
Copy link
Collaborator Author

blixtra commented Feb 4, 2016

Updated. Now with tests!!! 🎆

ctx := testutils.NewRktRunCtx()
defer ctx.Cleanup()

// Prepare image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to prepare the image since you run rkt run directly below

@iaguis iaguis added this to the v1.0.0 milestone Feb 4, 2016
@iaguis iaguis added the kind/bug label Feb 4, 2016
@blixtra blixtra force-pushed the ckuehl/stage1-dont-supress-errors branch from 9ac9bb8 to 8689498 Compare February 4, 2016 14:55
@blixtra
Copy link
Collaborator Author

blixtra commented Feb 4, 2016

Update.

@iaguis
Copy link
Member

iaguis commented Feb 4, 2016

LGTM on green

@alban
Copy link
Member

alban commented Feb 4, 2016

LGTM as well

alban added a commit that referenced this pull request Feb 4, 2016
@alban alban merged commit c0e31c6 into rkt:master Feb 4, 2016
@blixtra blixtra deleted the ckuehl/stage1-dont-supress-errors branch November 28, 2017 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants