-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OpenMM #4
Conversation
…mol to not recognize file names
Thanks @orioncohen ! I won't be able to look at this in much detail until early next week but I'm excited to see how your OpenMM support is shaping up. |
Sounds good! I believe that the OpenMM IO can fit into the new IO abstraction pretty cleanly by serializing all of the OpenMM objects needed to create a simulation The InputSetGenerator will be instantiated by user defined settings and create a Topology, System, Integrator, and Simulation. It will then serialize all of those objects into XML and store them. When The InputSet can then have a |
What should determine if a parameter goes in The documentation seems to indicate that only the structure and other critical parameters should go in |
# Conflicts: # requirements-optional.txt
…nerators to utils
Improvements on forcefield specification for mixed systems and specific water models
Implemented changes in comments, ran pre-commit
Did my best to address all comments
Added function to assign_biopolymer_and_water_ff
Adding unit tests for: 1. smiles with formal charge 2. Ensuring different water models assign different parameters 3. Testing mixing of small molecule ff with water ff Also removed tip4p support because it requires the addition of an extra particle. Need to figure that out
Fixed smiles string in test_formal_charge Be careful about smiles!!
ran black
Support for multiple forcefields
updates: - [github.com/PyCQA/autoflake: v1.4 → v1.6.1](PyCQA/autoflake@v1.4...v1.6.1) - [github.com/asottile/pyupgrade: v2.37.3 → v2.38.2](asottile/pyupgrade@v2.37.3...v2.38.2) - [github.com/psf/black: 22.6.0 → 22.8.0](psf/black@22.6.0...22.8.0) - [github.com/PyCQA/flake8: 5.0.2 → 5.0.4](PyCQA/flake8@5.0.2...5.0.4) - [github.com/pre-commit/mirrors-mypy: v0.971 → v0.981](pre-commit/mirrors-mypy@v0.971...v0.981) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Summary
Include a summary of major changes in bullet points:
Additional dependencies introduced (if any)
openmm: this is code for OpenMM IO
openff: needed to parameterize Sage Force Field
parmed: used to create suitably sized PDB files. Later may be used to add more force fields.
openbabel + rdkit are used, but they are already used in pymatgen.
TODO (if any)
better support for water models, at least allow the user to specify TIP3 or TIP4.
automatic partial charge assignment. It should be possible to include RESP partial charges in the parameterization.
allow partial charge scaling as a setting in the generator
Checklist
is to run the following in the correct sequence on your local machine. Start with running
black on your new code. This will automatically reformat
your code to PEP8 conventions and removes most issues. Then run
pycodestyle, followed by
flake8.
Run pydocstyle on your code.