-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customization of 'Now' and 'Clear' buttons in alt-date widget #938
Conversation
I'll update the docs and add a playground example, just wanted to make sure this gets merged / is the right approach first. |
I also added the possibility to edit the placeholders for the dropdowns. |
The code seems OK, but I guess I would bikeshed the names of the options. How about |
I can do that, I'd prefer the namespaced |
I will try and remember to update my TimeWidget and AltTimeWidget MRs to support this once we agree on the naming convention. |
@amiuhle -- are you still working on this? If so, could you update the names of the options and also add some tests? I like |
Is there an example for this? Or can you say what should be the code. |
@epicfaace Totally forgot about this, I'll have a look next week. |
@amiuhle just bumping this! |
74a1118
to
602ef5d
Compare
602ef5d
to
c2816c7
Compare
@epicfaace I put the placeholders / labels into namespaces, added docs and a placeholder example and added some tests. |
Any chance this can be merged? |
Closing in favor of #3460 |
Reasons for making this change
The Now and Clear buttons on the
alt-date
widget are static. This adds support for customization viaui:options
.Checklist
npm run cs-format
on my branch to conform my code to prettier coding style