Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of 'Now' and 'Clear' buttons in alt-date widget #938

Closed
wants to merge 9 commits into from

Conversation

amiuhle
Copy link

@amiuhle amiuhle commented May 23, 2018

Reasons for making this change

The Now and Clear buttons on the alt-date widget are static. This adds support for customization via ui:options.

Checklist

  • I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@amiuhle
Copy link
Author

amiuhle commented May 23, 2018

I'll update the docs and add a playground example, just wanted to make sure this gets merged / is the right approach first.

@amiuhle
Copy link
Author

amiuhle commented May 24, 2018

I also added the possibility to edit the placeholders for the dropdowns.

@glasserc
Copy link
Contributor

The code seems OK, but I guess I would bikeshed the names of the options. How about options.placeholders.year or options.yearPlaceholder instead of options.year?

@amiuhle
Copy link
Author

amiuhle commented May 28, 2018

I can do that, I'd prefer the namespaced options.placeholders.year option. How about the "Now" and "Clear" buttons? options.labels?

@r4j4h
Copy link
Contributor

r4j4h commented Jun 25, 2018

I will try and remember to update my TimeWidget and AltTimeWidget MRs to support this once we agree on the naming convention.

@epicfaace
Copy link
Member

@amiuhle -- are you still working on this? If so, could you update the names of the options and also add some tests? I like options.placeholders and options.labels as you suggested.

@swetapatnaik
Copy link

Is there an example for this? Or can you say what should be the code.

@amiuhle
Copy link
Author

amiuhle commented Jan 25, 2019

@epicfaace Totally forgot about this, I'll have a look next week.

@epicfaace
Copy link
Member

@amiuhle just bumping this!

@amiuhle
Copy link
Author

amiuhle commented Dec 10, 2019

@epicfaace I put the placeholders / labels into namespaces, added docs and a placeholder example and added some tests.

@amiuhle
Copy link
Author

amiuhle commented Jan 21, 2021

Any chance this can be merged?

@heath-freenome
Copy link
Member

Closing in favor of #3460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants