Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined target in onBlur and onFocus handlers #4227

Conversation

heath-freenome
Copy link
Member

There are some instances where the onBlur and onFocus handlers are receiving an undefined target, causing the following type error:

Cannot read properties of undefined (reading 'value')
  • Updated all of the onBlur() and onFocus() handlers in all libraries to fix this
  • Updated the CHANGELOG.md accordingly

Reasons for making this change

[Please describe them here]

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

There are some instances where the `onBlur` and `onFocus` handlers are receiving an undefined `target`, causing the following type error:
```
Cannot read properties of undefined (reading 'value')
```
- Updated all of the `onBlur()` and `onFocus()` handlers in all libraries to fix this
- Updated the `CHANGELOG.md` accordingly
@heath-freenome heath-freenome force-pushed the fix-undefined-target-in-blur-and-focus-handlers branch from 10adf97 to bae6d4b Compare June 21, 2024 20:21
Copy link
Contributor

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to know what causes this to happen. I am a bit concerned about passing false to these functions when target is null, but it will probably be ok.

@heath-freenome
Copy link
Member Author

It would be great to know what causes this to happen. I am a bit concerned about passing false to these functions when target is null, but it will probably be ok.

It really only seems to be an issue with the SelectWidget on semantic-ui but I'm not taking any changes

@heath-freenome heath-freenome merged commit f8378c4 into rjsf-team:main Jun 24, 2024
5 checks passed
@heath-freenome heath-freenome deleted the fix-undefined-target-in-blur-and-focus-handlers branch June 24, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants