Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement(Share): Enhancement base64 encoding/decoding using UTF-8 charset to support the characters outside the latin1 range. (#4024) #4034

Merged
merged 14 commits into from
Jan 18, 2024

Conversation

orange-guo
Copy link
Contributor

@orange-guo orange-guo commented Jan 9, 2024

Reasons for making this change

[Please describe them here]

This pr is the solution to issue #4024, this solution provide an object that uses the utf8 charset to do base64 operations(that using the utf8 charset to support the characters outside the latin1 range)

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

packages/playground/src/components/Header.tsx Outdated Show resolved Hide resolved
packages/playground/src/components/Playground.tsx Outdated Show resolved Hide resolved
packages/utils/src/base64.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@orange-guo orange-guo changed the title Enhancement(Share): Improve base64 encoding/decoding using UTF-8 charset to support the characters outside the latin1 range. (#4024) Enhancement(Share): Enhancement base64 encoding/decoding using UTF-8 charset to support the characters outside the latin1 range. (#4024) Jan 11, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@heath-freenome heath-freenome merged commit f31bef1 into rjsf-team:main Jan 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants