Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add typescript project reference for utils in validator-ajv6 and validator-ajv8 #3982

Merged
merged 1 commit into from
Nov 28, 2023
Merged

add typescript project reference for utils in validator-ajv6 and validator-ajv8 #3982

merged 1 commit into from
Nov 28, 2023

Conversation

zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Nov 28, 2023

Reasons for making this change

By not having project reference typescript build can fail depending on order in which packages are build in CI (as was noticed in #3969)

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@zxbodya zxbodya mentioned this pull request Nov 28, 2023
Merged
8 tasks
@heath-freenome heath-freenome merged commit bc16e29 into rjsf-team:main Nov 28, 2023
4 checks passed
@zxbodya zxbodya deleted the fix-missing-references branch November 29, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heath-freenome heath-freenome heath-freenome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxbodya @heath-freenome