fix: deal with edage case in errorPropertyToPath #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0
suggested changes
Nov 16, 2016
| } | ||
| return path; | ||
| }, []); | ||
| // copied from lodash https://github.com/lodash/lodash/blob/4.17.1/lodash.js#L6744 |
There was a problem hiding this comment.
Seems like we could use https://lodash.com/docs/4.17.2#toPath directly. I think lodash allows importing functions atomically, so this shouldn't bloat the build too much.
|
Thanks for contributing 👍 |
n1k0
added a commit
that referenced
this pull request
Nov 25, 2016
* Update dependencies to their latest versions. (#386) * Fix #385: Avoid dynamic requires. (#387) * Fix #365: Tab stop for Add button + (#392) * Add a single field form example in the playground (#390) * Allow using field names containing a dot character (#397) * Updated eslint config. * Improve checkbox and radio button styles (#403) * Add missing proptype for disabled (#416) * Temporary fix for #349 and facebook/react#7630 radio widget bug (#423)
|
Released along v0.41.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
When there is '.' in side a key of an object, the errorPropertyToPath function failed to parse the string into a path array.
Checklist