Fixes #176: Reset errors after submit & new data are entered. #177
Conversation
n1k0
changed the title
n1k0
changed the title
| @@ -61,8 +61,7 @@ export default class Form extends Component { | |||
|
|
|||
| onChange = (formData, options={validate: false}) => { | |||
| const liveValidate = this.props.liveValidate || options.validate; | |||
| const errors = liveValidate ? this.validate(formData) : | |||
| this.state.errors; | |||
| const errors = liveValidate ? this.validate(formData) : []; | |||
There was a problem hiding this comment.
Will this reset every errors ?
It should reset the error of the field being changed, no ?
There was a problem hiding this comment.
Well that's a possibility but when liveValidate is not enabled, you basically have to resubmit the form to have errors rendered again. I could see a UX scenario where you discard errors field by field as soon as they're fixed, but that's one of the main purpose of liveValidate :)
There was a problem hiding this comment.
I'll add a checkbox in the playground to enable/disable live validation so we'll figure out how usable it this.
There was a problem hiding this comment.
Added live validation toggler to the playground, you're definitely right wrt surprising behavior. Il revamp the patch.
- More consistent non-live validation behavior. - Added live validation toggler to playground.
n1k0
force-pushed
the
176-previous-errors-cleanup
branch
from
19aa552
to
8dd3f7f
Compare
|
Playground has been updated with this patch. Feedback welcome. http://mozilla-services.github.io/react-jsonschema-form/ |
|
Well, I think I'm gonna land this. r=me |
| Simulate.submit(node); | ||
| } catch(err) { | ||
| // Ditto. | ||
| } |
There was a problem hiding this comment.
Why this? It seems like the submit just above should take care of this?
There was a problem hiding this comment.
haha good catch, thanks :) this test has been revamped in the meanwhile though.
Edit: woops nope it hasn't. Will fix.
r=? @leplatrem
/cc @kaihendry