Fixes #137: Prevent non-required fields to fill state with defaults. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0
force-pushed
the
137-fix-non-required-number
branch
2 times, most recently
from
43225bd
to
a4a5fad
Compare
|
I'm gonna move the default value for datetime into the widget itself. Edit: It was already defined in the |
|
Deployed the changes to gh-pages http://mozilla-services.github.io/react-jsonschema-form/ |
n1k0
force-pushed
the
137-fix-non-required-number
branch
from
a1c2287
to
ca00c08
Compare
|
it's a pity that we're obliged to repeat the r+ otherwise :) (as long as the default datetime is still «now») |
r=@leplatrem - Dropped obsolete defaultTypeValue helper. - Avoid having uncontrolled widgets components. - Ensure no React warning can pass through the test suites.
n1k0
force-pushed
the
137-fix-non-required-number
branch
from
ca00c08
to
7847a73
Compare
Factored this. I'm gonna land the patch after #132 is landed, as it probably conflicts heavily. |
|
I need to land this now and make a release as this fixes a bunch of issues we need on other projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #137, /cc @alexmnguyen.
We should carefully review this one at is has possible strong impact on forms behavior, though couldn't spot any problem in tests and in the playground.
r=? @leplatrem @magopian