Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated code to use React 15.0.1. #131

Merged
merged 1 commit into from
Apr 10, 2016
Merged

Migrated code to use React 15.0.1. #131

merged 1 commit into from
Apr 10, 2016

Conversation

n1k0
Copy link
Collaborator

@n1k0 n1k0 commented Apr 9, 2016

Changes:

  • All references to defaultValue have been removed from widgets, as React 15.0.1 requires to choose between controlled and uncontrolled input components.
  • Related, tests relying on selecting input tags from their value attribute have been updated accordingly.

Todo

  • Update docs to reflect removal of passed defaultValue widget prop.

@n1k0
Copy link
Collaborator Author

n1k0 commented Apr 9, 2016

Interestingly, Travis builds fail while tests are green on my box. Edit: fixed, my bad.

@n1k0 n1k0 force-pushed the react-15.0.1 branch 3 times, most recently from 344711b to 8489855 Compare April 9, 2016 13:30
@n1k0
Copy link
Collaborator Author

n1k0 commented Apr 9, 2016

I've deployed the React 15.0.1-powered version of the playground to http://mozilla-services.github.io/react-jsonschema-form/

Feedback welcome.

@n1k0
Copy link
Collaborator Author

n1k0 commented Apr 10, 2016

r=me

@n1k0 n1k0 merged commit 19921c5 into master Apr 10, 2016
@n1k0 n1k0 deleted the react-15.0.1 branch April 10, 2016 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant