-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to install "@rjsf/antd" theme to project with latest (5.3.1) Ant Design #3507
Comments
Same here package.json "@ant-design/icons": "^5.0.1",
"@rjsf/core": "^5.2.1", When install npm ERR! Found: @ant-design/icons@5.0.1
npm ERR! node_modules/@ant-design/icons
npm ERR! @ant-design/icons@"^5.0.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @ant-design/icons@"^4.0.0" from @rjsf/antd@5.2.1
npm ERR! node_modules/@rjsf/antd
npm ERR! @rjsf/antd@"*" from the root project
|
@Deemetr @Napalm4577 We would love some help upgrading the |
Reading Ant Design V4 to V5 migration guide it seems that the only breaking change introduced in V5 (that affects RJSF Antd theme) is the deprecation of moment.js in favor of day.js I think this can be removed and instead use the default datepicker exposed by AntD FYI: Just forced the installation of Antd v5 on my repo which is using RJSF v5, and everything worked out just fine. |
@fran122157 That is good information. How do the default date pickers differ? Also, are you willing to provide a PR for the fix? |
What I meant is that this generatePicker call used to change Antd default date lib from moment.js to day.js is no longer necessary as Antd already uses day.js in v5 so here and here you could just use the default Antd exported datepicker |
I have created a PR in my own fork. There's a change I did not see that was introduced in v5: Removal of less files in Antd codebase. FYI: The PR is just for reference, I tried to test my changes in the playground but I have to link my local changes with the antd version the playground is using and I do not have the time right now. Please feel free to use any of these changes |
May I help with this? |
@heath-freenome Is there any progress? |
I still get the error with the last version:
|
@Gam3sFan thanks for catching that. I will update the peer dependencies in the patch release soon |
Fixes: rjsf-team#3507 to allow v5 `@ant-design/icons` - Updated the `antd` package.json to add `@ant-design/icons` v5 to the peer dependencies
Fixes: rjsf-team#3507 to allow v5 `@ant-design/icons` - Updated the `antd` package.json to add `@ant-design/icons` v5 to the peer dependencies - Updated the `CHANGELOG.md` accordinglyl
Fixes: #3507 to allow v5 `@ant-design/icons` - Updated the `antd` package.json to add `@ant-design/icons` v5 to the peer dependencies - Updated the `CHANGELOG.md` accordinglyl
@Gam3sFan The release should be ready in a few hours |
Prerequisites
What theme are you using?
antd
Version
5.x
Current Behavior
Expected Behavior
Installed
@rjsf/antd
packageSteps To Reproduce
npm install antd
)@rjsf/antd
(npm i @rjsf/antd
)Or
https://github.com/Deemetr/-rjsf-antd__issue
-rjsf-antd__issue
npm i
Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: