Correct return parameter order; fix rune counts #489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 58.48% 58.48%
=======================================
Files 54 54
Lines 10761 10761
=======================================
Hits 6294 6294
Misses 4032 4032
Partials 435 435
|
exec.go
Outdated
| if aa != "" { | ||
| t.w.Eventf("%c0 0 0 %d %v\n", c, len(aa), aa) | ||
| t.w.Eventf("%c0 0 0 %d %v\n", c, len([]rune(aa)), aa) |
There was a problem hiding this comment.
And now I'm not sure about this one. I'd like the interface across the channel to be counted in runes, not bytes. But I have only the evidence of win's implementation, and of Russ's acme port that this is the case.
We need tests.
There was a problem hiding this comment.
Ok, carefully re-reading the man page, russ's go code, the original acme code, I believe that yes, the "number of characters" refers to runes, not bytes. But the rune counts change should be a separate CL. I'll split it off.
Fix #487; possibly also #470