Remove RZ_NULLABLE from RzSearchFindBytesCallback function pointer type #4929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazarmy
requested review from
wargio,
thestr4ng3r,
ret2libc and
Rot127
as code owners
Rot127
approved these changes
Feb 24, 2025
Is 041f911 ok? |
Rot127
approved these changes
Feb 24, 2025
notxvilka
approved these changes
Feb 24, 2025
wargio
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
This pr removes
RZ_NULLABLEfrom thefoptparameter of theRzSearchFindBytesCallbackfunction pointer type, because defaults should be in one place rather than scattered through code. Sorry, forgot to do the removal in #4928.Test plan
All builds are green.
Closing issues
...