Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PIC instruction sets (asm.cpu) #4927

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Rename PIC instruction sets (asm.cpu) #4927

merged 1 commit into from
Feb 23, 2025

Conversation

thestr4ng3r
Copy link
Member

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

To conform to official naming from Microchip:

  • pic14 -> baseline
  • pic16 -> midrange
  • pic18 -> highend (with pic18 being an alias)

@thestr4ng3r
Rename PIC instruction sets (asm.cpu)
260302d 
To conform to official naming from Microchip:
- pic14 -> baseline
- pic16 -> midrange
- pic18 -> highend (with pic18 being an alias)
@notxvilka notxvilka merged commit 6720849 into dev Feb 23, 2025
49 checks passed
@notxvilka notxvilka deleted the pic-rename branch February 23, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rot127 Rot127 Rot127 approved these changes

@notxvilka notxvilka notxvilka approved these changes

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
PIC rz-test RzAnalysis RZIL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thestr4ng3r @Rot127 @notxvilka