HP PA-RISC: Migrate to Capstone and add basic analysis #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wargio
reviewed
May 5, 2024
| ctx->insn = NULL; | ||
| ctx->count = cs_disasm(ctx->h, buf, len, a->pc, 1, &ctx->insn); | ||
| if (ctx->count <= 0) { | ||
| RZ_LOG_ERROR("HPPA: disasm error @ 0x%08" PFMT64x ", len = %d\n", a->pc, len); |
There was a problem hiding this comment.
It's here for debugging. Once PR is ready I will remove.
12 tasks
notxvilka
force-pushed
the
asan-hppa-arch
branch
from
45de281 to
aa4f3b6
Compare
notxvilka
requested review from
ret2libc,
kazarmy,
thestr4ng3r and
Rot127
as code owners
Rot127
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Other architectures had the same "convention", I just followed it.
There was a problem hiding this comment.
Better not do it like this. Depending on the editor it can be annoying to debug, because it is not automatically detected as C file. Syntax highlighting fails etc.
So if their is no immediate advantage for it, better make it a normal .c file.
Comment on lines
+41
to
+47
| #define TOKEN(_type, _pat) \ | ||
| do { \ | ||
| RzAsmTokenPattern *pat = RZ_NEW0(RzAsmTokenPattern); \ | ||
| pat->type = RZ_ASM_TOKEN_##_type; \ | ||
| pat->pattern = strdup(_pat); \ | ||
| rz_pvector_push(pvec, pat); \ | ||
| } while (0) |
There was a problem hiding this comment.
We should probably move this to a general header. No idea which one though
notxvilka
force-pushed
the
asan-hppa-arch
branch
2 times, most recently
from
60c7146 to
60b531f
Compare
notxvilka
force-pushed
the
asan-hppa-arch
branch
from
60b531f to
327c38d
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Now it is able to derive control flow properly for most common instructions:
Test plan
CI is green
Closing issues
Partially addresses rizinorg/ideas#1
Partially addresses #2704
Useful information