Rewrite non-libuv tcp server and drop libuv #2857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestr4ng3r
force-pushed
the
drop-libuv
branch
3 times, most recently
from
074a964 to
d5b9a30
Compare
thestr4ng3r
requested review from
ret2libc,
XVilka,
yossizap,
wargio and
kazarmy
as code owners
wargio
reviewed
Jul 31, 2022
wargio
reviewed
Jul 31, 2022
The non-libuv tcp server implementation had several issues: * Relied on EINTR or self-connect through global vars for breaking, which did not work during recv() for example. * Never retried on EINTR * Called recv() only once, thus subject to fragmentation issues To support breaking otherwise blocking socket calls, RzStopPipe has been imported from chiaki (I am the sole author so I can relicense). rz_socket_block_time() was also detected to be doing the exact opposite than it should on Windows through the tests, and fixed.
libuv was only ever used for the tcp server for almost 4 years. Since the non-libuv implementation of that is working now, it can be dropped entirely without sacrificing functionality.
4 tasks
XVilka
requested changes
Jul 31, 2022
There was a problem hiding this comment.
Resend this from dist-asan-fuzz- branch, please.
@GustavoLCR could you please take a look if everything is fine from the Windows point of view?
|
|
||
| uv_tcp_t *client = RZ_NEW(uv_tcp_t); | ||
| if (!client) { | ||
| RZ_API void rz_core_rtr_cmds(RzCore *core, const char *port) { |
| @@ -716,7 +724,7 @@ RZ_API char *rz_socket_to_string(RzSocket *s) { | |||
| } | |||
| return str; | |||
| #else | |||
| return NULL; | |||
| return NULL; | |||
There was a problem hiding this comment.
clang-format enforces it, but it makes no sense imo.
| #endif | ||
| }; // RzStopPipe | ||
|
|
||
| RZ_API RzStopPipe *rz_stop_pipe_new(void) { |
There was a problem hiding this comment.
Doxygen with explanation what exactly RzStopPipe is?
|
Superseded by #2860 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH
Your checklist for this pull request
Detailed description
Despite being a fantastic library, libuv was only ever used for the tcp server for almost 4 years. This fixes the non-libuv tcp server and drops libuv in favor of it. See commit descriptions for details.
Test plan
Warning: if
tcp.islocal=false, the following will open complete shell access to0.0.0.0!rz -c "Rt 1337", then from another terminal do e.g.echo "?E hello" | nc localhost 1337and see the command output.Ctrl+C should also break the
Rtcommand properly.