Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Layered Architecture #21

Merged
merged 2 commits into from
May 10, 2022
Merged

Implement Layered Architecture #21

merged 2 commits into from
May 10, 2022

Conversation

rizalgowandy
Copy link
Owner

Segregate logic between storage, business, and controller domain.

@github-actions github-actions bot added the enhancement New feature or request label May 10, 2022
@github-actions
Copy link
Contributor

Code Metrics Report

main (5658457) #21 (8e48750) +/-
Coverage 46.3% 43.9% -2.4%
Code to Test Ratio 1:0.9 1:0.8 -0.1
Test Execution Time 24s 19s -5s
Details
  |                     | main (5658457) | #21 (8e48750) |  +/-  |
  |---------------------|----------------|---------------|-------|
- | Coverage            |          46.3% |         43.9% | -2.4% |
  |   Files             |             18 |            19 |    +1 |
  |   Lines             |            415 |           433 |   +18 |
- |   Covered           |            192 |           190 |    -2 |
- | Code to Test Ratio  |          1:0.9 |         1:0.8 |  -0.1 |
  |   Code              |           1623 |          1630 |    +7 |
- |   Test              |           1387 |          1279 |  -108 |
+ | Test Execution Time |            24s |           19s |   -5s |

Code coverage of files in pull request scope (65.1% → 51.6%)

Files Coverage +/-
cronx.go 64.0% -11.3%
cronx_history.go 0.0% 0.0%
cronx_status_sort.go 14.6% +14.6%
job.go 84.9% 0.0%
page/status.go 100.0% 0.0%
server.go 22.0% +6.1%
status.go 100.0% 0.0%

Reported by octocov

@rizalgowandy rizalgowandy merged commit 6292b67 into main May 10, 2022
@rizalgowandy rizalgowandy deleted the arwego/feat/v2 branch May 10, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant