Merge pull request #27 from rizalgowandy/arwego/feat/v2

Add Minimum Latency to Trigger Alert
rizalgowandy · May 30, 2022 · 916832c · 916832c
2 parents 624a690 + c587b49
commit 916832c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/job.go b/job.go
@@ -149,7 +149,7 @@ func (j *Job) Run() {
 	j.RecordHistory(ctx, start, finish)
 
 	// Send alert if high latency is detected.
-	if latency > maxLatency {
+	if latency > maxLatency && latency > time.Second {
 		j.manager.alerter.NotifyHighLatency(ctx, j, prev, next, latency, maxLatency)
 	}
 }

diff --git a/job_test.go b/job_test.go
@@ -141,7 +141,6 @@ func TestNewJob(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			manager := NewManager()
 			got := NewJob(manager, tt.args.job, tt.args.waveNumber, tt.args.totalWave)
-			t.Log(got)
 			assert.NotNil(t, got)
 		})
 	}