Error on batch insert if InsertOpts.UniqueOpts is specified
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
approved these changes
Nov 11, 2023
| if err := c.validateManyInsertOpts(param.InsertOpts); err != nil { | ||
| return 0, err | ||
| } | ||
|
|
There was a problem hiding this comment.
These method bodies are getting to be fairly long for being entirely duplicated, thoughts on extracting everything except the last line of each into a shared unexported method or helper?
There was a problem hiding this comment.
WFM. Updated to include Client.insertManyParams.
brandur
force-pushed
the
brandur-error-on-batch-unique-opts
branch
from
3d679e4 to
dced48f
Compare
As I was writing docs for batch insertion today [1], I remembered that we don't support job uniqueness on batch inserts because the mechanism uses PG advisory locks, and holding many locks at once could easily lead to contention and deadlocks. We may remove this limitation in the future, but I figure that in the meantime, it might not be the worst idea to error if they're specified on batch insert so as not to mislead the user that what they expected to happen happened. That's what this change does. [1] https://riverqueue.com/docs/batch-job-insertion
brandur
force-pushed
the
brandur-error-on-batch-unique-opts
branch
from
dced48f to
b07d2af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was writing docs for batch insertion today [1], I remembered that
we don't support job uniqueness on batch inserts because the mechanism
uses PG advisory locks, and holding many locks at once could easily lead
to contention and deadlocks.
We may remove this limitation in the future, but I figure that in the
meantime, it might not be the worst idea to error if they're specified
on batch insert so as not to mislead the user that what they expected to
happen happened. That's what this change does.
[1] https://riverqueue.com/docs/batch-job-insertion