Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using GitHub action #86

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Using GitHub action #86

merged 2 commits into from
Jun 29, 2021

Conversation

mjtalbot
Copy link
Collaborator

ok updated to use our very own 'action'

revved cpp as well, as the alerts are getting annoying.

with:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
REPO_GIT_URL: https://github.com/rive-app/rive-cpp.git
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this could be SUBMODULE_REPO_GIT_URL. or SUBMODULE_GIT_URL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally get how uses works, this is awesome.

@mjtalbot
Copy link
Collaborator Author

Copy link
Contributor

@luigi-rosso luigi-rosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

@mjtalbot mjtalbot merged commit 880b87a into master Jun 29, 2021
@mjtalbot mjtalbot deleted the usingGithubAction branch July 30, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants