Add NSError errors in place of NSException #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjtalbot
reviewed
Jun 25, 2021
| RiveLinearAnimation* animation2ByIndex = [artboard animationFromIndex:1 error:&error]; | ||
| XCTAssertNil(error); | ||
| RiveLinearAnimation* animation2ByName = [artboard animationFromName:@"artboard2animation2" error:&error]; | ||
| XCTAssertNil(error); |
mjtalbot
reviewed
Jun 25, 2021
|
|
||
| XCTAssertNil(animation); | ||
| XCTAssertNotNil(error); | ||
| XCTAssertEqualObjects([error domain], @"rive.app.ios.runtime"); |
There was a problem hiding this comment.
can probably wrap this set into some helper thingie, looks like there's some duplication going on here
mjtalbot
reviewed
Jun 25, 2021
| let delegate = MrDelegate() | ||
| let view = RiveView.init( | ||
| let view = try RiveView.init( |
There was a problem hiding this comment.
so this magically bubbles em up eh?
mjtalbot
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will require a major version bump.