Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Error while compile SASS using grid name on CSS Grid #40

Closed
alebarbaja opened this issue Feb 7, 2018 · 9 comments
Closed

Error while compile SASS using grid name on CSS Grid #40

alebarbaja opened this issue Feb 7, 2018 · 9 comments

Comments

@alebarbaja
Copy link

I want to use grid names for specify my CSS Grid, but when I have to compile it gave me an error.

error-sass-vscode

The code it works, because I put it on my css file without compile and simply works.

Thank you.

@riczorn
Copy link

riczorn commented Mar 26, 2018

hi, possibly update the sass.js to 0.10.9 (this ships with 0.10.5) in:

  • ./home/user/.vscode/extensions/ritwickdey.live-sass-1.3.0/lib/sasslib/sass.js
  • ./home/user/.vscode/extensions/ritwickdey.live-sass-1.3.0/node_modules/sasslib/sass.js

I couldn't get it to find my scss files because it prefixes them with /sass in the path... I am not going to symlink /sass to the root though, I'm going back to ruby-sass on the command line.

@frankievalentine
Copy link

frankievalentine commented Mar 27, 2018

Found a workaround that includes using the unquote function and it successfully compiled.

grid-template-columns: unquote("[start] 2fr [smallbanner-end bigbanner-start] 1fr [end]");

Hope this helps and is fixed in a future update.

@inanutshell86
Copy link

This error still occurs

@ritwickdey
Copy link
Owner

Sorry for late. I started working again for this project.

Can anyone please paste the code block which is not working?

@ritwickdey ritwickdey self-assigned this Jun 24, 2018
@ritwickdey ritwickdey added the bug label Jun 24, 2018
@inanutshell86
Copy link

grid-template-columns: [main-start] 1fr [content-start] 1fr [content-end] 1fr [main-end];

@ritwickdey
Copy link
Owner

Sorry, this is a library issue. This extension is depended on sass.js and sass.js build top on SassLib (Core library, built top on C++).

SassLib is fixed this issue from 3.5.x. But the problem is that sass.js is not yet upgraded. They are using SassLib@3.4.x.

I was trying to upgrde the sass.js locally (by cloing the project). I don't it is not working. May be the configuration is defined only for MacOs only. I was trying from Linux - it is not working - correpted files are generating. & I don't have MacOS.

@ritwickdey
Copy link
Owner

Building the lib using Travis CI (Mac Build) may work. I've to spend more time.

ritwickdey added a commit that referenced this issue Jul 11, 2018
ritwickdey added a commit that referenced this issue Jul 11, 2018
@ritwickdey
Copy link
Owner

This issue has been fixed from v3.0.0. Please let know if it's still not working.
Thanks for the report.

@dayoesq
Copy link

dayoesq commented Jun 28, 2019

I have similar issue. I get compilation errors. I guess this issue is not fixed yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants