Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation in MARC tags with multiple subfields #1128

Open
jenniferward opened this issue Jul 7, 2021 · 8 comments
Open

Validation in MARC tags with multiple subfields #1128

jenniferward opened this issue Jul 7, 2021 · 8 comments

Comments

@jenniferward
Copy link
Contributor

Just noticed that some people are filling out 856 $z and $x even if there is no URL in $u. So we need a validation that looks at the whole field - if 1 subfield is filled out, then all 3 need to be filled out.

@jenniferward jenniferward changed the title Validation in 856 Validation in MARC tags with multiple subfields Jul 13, 2021
@jenniferward
Copy link
Contributor Author

Editing this to include more fields that have subfields. Catalogers sometimes fill out a function (700$4, 710$4) or a literature reference (690$n, 691$n) but forget the person or book, and they would appreciate a warning here so that they can fix it.

So:
700:
If $j or $4 is filled out, then $a required

710:
If $j or $4 is filled out, then $a required

690:
If $n filled out, then $a required
If $a filled out, then $n required

691:
If $n filled out, then $a required
BUT: 691$a can exist by itself (sometimes $n is not necessary)

510:
If $c is filled out, then $a is required
If $a is filled out, then $c is required

596:
If $a is filled out, then $b is required
If $b is filled out, then $a is required

@xhero xhero self-assigned this Aug 31, 2021
@xhero xhero added this to the Muscat 7.1.2 milestone Aug 31, 2021
@xhero
Copy link
Contributor

xhero commented Aug 31, 2021

For 700 and 710 I cannot reproduce the bug, as leaving $a empty will always trigger an error for me - is there a special way this is done?

xhero added a commit that referenced this issue Aug 31, 2021
@jenniferward
Copy link
Contributor Author

jenniferward commented Aug 31, 2021

I was thinking of the error reports that had the empty $a. Maybe it was only in old records. You're right, I'm getting errors (as expected) too.

@xhero xhero closed this as completed in 0d5263d Aug 31, 2021
xhero added a commit that referenced this issue Aug 31, 2021
* develop:
  Fix #516, make sure the + sign is only in the first element
  Show all subtags for 852, remove the partial, it was used for linking but that is done automatically now.
  Fix #1128, properly show errors on select items
  #1128 Add validations
  Fix #1138, implement validation to avoid 787 and 773 pointing to themselves.
@jenniferward
Copy link
Contributor Author

Was this implemented, or is it yet to come? We had an empty 856$u recently (https://muscat.rism.info/admin/sources/1001171784).

@xhero
Copy link
Contributor

xhero commented Sep 29, 2021

Oh, I realized I implemented all of them except 856$u

@xhero xhero reopened this Sep 29, 2021
@xhero xhero modified the milestones: Muscat 7.1.2, Muscat 7.2 Sep 29, 2021
@xhero
Copy link
Contributor

xhero commented Dec 8, 2021

I will move this to 8.1, the problem is that a field can be validated only by one rule, and 856 $u already has a begins_with rule.

@jenniferward
Copy link
Contributor Author

Giving this a boost because there are also some records where just one subfield in 856 is filled out, likely just through misclicking.
856 containing only $x:

The validation should catch such cases and we should add it to the health report. We'd also need a list of 856s missing multiple fields so we can fix them.

@jenniferward
Copy link
Contributor Author

jenniferward commented Oct 16, 2024

Also relevant: People: Validation for 024 #1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants