Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix running simulation test on ARM64 macOS #6885

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

wangrunji0408
Copy link
Contributor

@wangrunji0408 wangrunji0408 commented Dec 13, 2022

Signed-off-by: Runji Wang wangrunji0408@163.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. See the change and explanations in madsim-rs/madsim#95.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

madsim-rs/madsim#95

Signed-off-by: Runji Wang <wangrunji0408@163.com>
@github-actions github-actions bot added the type/fix Bug fix label Dec 13, 2022
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too fast! 🥵

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #6885 (bad757c) into main (845c5a5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6885   +/-   ##
=======================================
  Coverage   73.21%   73.22%           
=======================================
  Files        1031     1031           
  Lines      164642   164642           
=======================================
+ Hits       120545   120554    +9     
+ Misses      44097    44088    -9     
Flag Coverage Δ
rust 73.22% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/source/src/row_id.rs 91.01% <0.00%> (-1.13%) ⬇️
src/connector/src/source/base.rs 77.88% <0.00%> (-0.97%) ⬇️
...frontend/src/scheduler/hummock_snapshot_manager.rs 58.29% <0.00%> (-0.51%) ⬇️
src/stream/src/executor/aggregation/minput.rs 96.49% <0.00%> (+0.10%) ⬆️
src/batch/src/executor/group_top_n.rs 74.85% <0.00%> (+6.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit d0c0a55 into main Dec 13, 2022
@mergify mergify bot deleted the wrj/fix-madsim branch December 13, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants