-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump dependencies #6423
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Shall we ignore the precision error of |
I think it can be ignored. |
I'll fix that |
Codecov Report
@@ Coverage Diff @@
## main #6423 +/- ##
==========================================
- Coverage 74.05% 74.05% -0.01%
==========================================
Files 966 972 +6
Lines 157832 158072 +240
==========================================
+ Hits 116887 117061 +174
- Misses 40945 41011 +66
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Why part of the common deps are managed by workspace.dependencies, while others by hakari? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hakari is for unifying features, and workspace dependencies is for unifying versions. |
* chore(deps): bump dependencies Signed-off-by: Bugen Zhao <i@bugenzhao.com> * fix Signed-off-by: Bugen Zhao <i@bugenzhao.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Bugen Zhao 2 i@bugenzhao.com
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)