Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump dependencies #6423

Merged
merged 3 commits into from
Nov 17, 2022
Merged

chore(deps): bump dependencies #6423

merged 3 commits into from
Nov 17, 2022

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Nov 17, 2022

Signed-off-by: Bugen Zhao 2 i@bugenzhao.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@skyzh
Copy link
Contributor

skyzh commented Nov 17, 2022

Shall we ignore the precision error of parser::json_parser::tests::test_json_parser? cc @tabVersion @waruto210

@waruto210 waruto210 closed this Nov 17, 2022
@waruto210 waruto210 reopened this Nov 17, 2022
@waruto210
Copy link
Contributor

Shall we ignore the precision error of parser::json_parser::tests::test_json_parser? cc @tabVersion @waruto210

I think it can be ignored.

@skyzh
Copy link
Contributor

skyzh commented Nov 17, 2022

I'll fix that

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #6423 (bfe4b3b) into main (37ae311) will decrease coverage by 0.00%.
The diff coverage is 72.45%.

@@            Coverage Diff             @@
##             main    #6423      +/-   ##
==========================================
- Coverage   74.05%   74.05%   -0.01%     
==========================================
  Files         966      972       +6     
  Lines      157832   158072     +240     
==========================================
+ Hits       116887   117061     +174     
- Misses      40945    41011      +66     
Flag Coverage Δ
rust 74.05% <72.45%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/row_seq_scan.rs 20.20% <ø> (ø)
src/batch/src/task/task_execution.rs 50.29% <0.00%> (ø)
src/compute/src/lib.rs 2.56% <0.00%> (-0.07%) ⬇️
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/connector/src/aws_utils.rs 0.00% <0.00%> (ø)
src/connector/src/source/cdc/enumerator/mod.rs 0.00% <0.00%> (ø)
src/connector/src/source/cdc/source/message.rs 0.00% <0.00%> (ø)
src/connector/src/source/cdc/source/reader.rs 0.00% <0.00%> (ø)
src/connector/src/source/cdc/split.rs 0.00% <0.00%> (ø)
src/connector/src/source/filesystem/s3/s3_dir.rs 0.00% <0.00%> (ø)
... and 124 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TennyZhuang
Copy link
Contributor

Why part of the common deps are managed by workspace.dependencies, while others by hakari?

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyzh
Copy link
Contributor

skyzh commented Nov 17, 2022

Why part of the common deps are managed by workspace.dependencies, while others by hakari?

Hakari is for unifying features, and workspace dependencies is for unifying versions.

@mergify mergify bot merged commit f88b680 into main Nov 17, 2022
@mergify mergify bot deleted the bz2/bump branch November 17, 2022 14:14
xxchan pushed a commit that referenced this pull request Nov 19, 2022
* chore(deps): bump dependencies

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

* fix

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants