Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add back e2e workflows for dev profile to main branch #6264

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Nov 9, 2022

Signed-off-by: Bugen Zhao i@bugenzhao.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR adds back the CI workflows for dev profile to the main branch, so that we're able to track the build/test performance with dev profile more easily, which matters for the developing experience.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #6264 (da524d1) into main (5c8c1e0) will decrease coverage by 0.21%.
The diff coverage is 43.49%.

@@            Coverage Diff             @@
##             main    #6264      +/-   ##
==========================================
- Coverage   74.60%   74.39%   -0.22%     
==========================================
  Files         947      948       +1     
  Lines      153125   153438     +313     
==========================================
- Hits       114238   114149      -89     
- Misses      38887    39289     +402     
Flag Coverage Δ
rust 74.39% <43.49%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/compute/src/rpc/service/exchange_service.rs 0.00% <0.00%> (ø)
src/compute/src/rpc/service/monitor_service.rs 0.00% <0.00%> (ø)
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/bench.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/table/scan.rs 0.00% <0.00%> (ø)
...c/catalog/system_catalog/information_schema/mod.rs 0.00% <0.00%> (ø)
src/frontend/src/catalog/view_catalog.rs 0.00% <0.00%> (ø)
src/frontend/src/optimizer/plan_node/mod.rs 85.49% <ø> (ø)
...frontend/src/optimizer/plan_node/plan_tree_node.rs 40.25% <0.00%> (-18.24%) ⬇️
...ntend/src/optimizer/plan_node/plan_tree_node_v2.rs 0.00% <0.00%> (ø)
... and 108 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BugenZhao BugenZhao requested a review from huangjw806 November 9, 2022 06:32
@BugenZhao BugenZhao marked this pull request as ready for review November 9, 2022 06:32
@BugenZhao BugenZhao requested review from tabVersion and skyzh November 9, 2022 06:32
@BugenZhao BugenZhao changed the title chore(ci): add back workflows for dev profile to main branch chore(ci): add back e2e workflows for dev profile to main branch Nov 9, 2022
@mergify mergify bot merged commit b599ecc into main Nov 9, 2022
@mergify mergify bot deleted the bz/add-back-dev-profile-to-main-workflow branch November 9, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants