feat(streaming): permit-based back-pressure in exchange #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Codecov Report
@@ Coverage Diff @@
## main #6170 +/- ##
==========================================
+ Coverage 74.18% 74.19% +0.01%
==========================================
Files 944 945 +1
Lines 152310 152387 +77
==========================================
+ Hits 112992 113066 +74
- Misses 39318 39321 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BugenZhao
changed the title
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
requested review from
yuhao-su,
StrikeW,
st1page,
fuyufjh,
liurenjie1024 and
KeXiangWang
|
LGTM! |
yuhao-su
approved these changes
Nov 4, 2022
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
This was referenced Nov 7, 2022
st1page
pushed a commit
that referenced
this pull request
Nov 16, 2022
* add channel Signed-off-by: Bugen Zhao <i@bugenzhao.com> * remote permits Signed-off-by: Bugen Zhao <i@bugenzhao.com> * extract batched permits Signed-off-by: Bugen Zhao <i@bugenzhao.com> * add license header Signed-off-by: Bugen Zhao <i@bugenzhao.com> * remove const Signed-off-by: Bugen Zhao <i@bugenzhao.com> * add doc Signed-off-by: Bugen Zhao <i@bugenzhao.com> * add more doc Signed-off-by: Bugen Zhao <i@bugenzhao.com> * gen ts proto * add more doc Signed-off-by: Bugen Zhao <i@bugenzhao.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com>
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
The hanging channel is a channel that's external for a table fragments subgraph. We introduced this for MV on MV long ago, but after #4045 and #6170, this becomes not that necessary: we can simply create a pair of channels if not found in the `ChannelPool`. https://github.com/risingwavelabs/risingwave/blob/b1891423a68b98dff39d7220a891cdea8bd67951/src/stream/src/task/mod.rs#L123-L138 This is a preparation step for #7908. Approved-By: yezizp2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Implement the permit-based back-pressure in exchange. doc
Take TPCH Q12 mentioned in the doc as an example:
Before:
After:
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)