Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog): stub system tables for sqlancer support #6169

Merged
merged 12 commits into from
Nov 9, 2022

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Nov 2, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Stub remaining system tables for sqlancer. WIP.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

#3364

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #6169 (548ca81) into main (5c8c1e0) will decrease coverage by 0.18%.
The diff coverage is 54.52%.

@@            Coverage Diff             @@
##             main    #6169      +/-   ##
==========================================
- Coverage   74.60%   74.41%   -0.19%     
==========================================
  Files         947      949       +2     
  Lines      153125   153724     +599     
==========================================
+ Hits       114238   114396     +158     
- Misses      38887    39328     +441     
Flag Coverage Δ
rust 74.41% <54.52%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/compute/src/lib.rs 2.63% <ø> (ø)
src/compute/src/rpc/service/exchange_service.rs 0.00% <0.00%> (ø)
src/compute/src/rpc/service/monitor_service.rs 0.00% <0.00%> (ø)
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/connector/src/sink/kafka.rs 31.22% <0.00%> (-1.14%) ⬇️
src/connector/src/sink/mod.rs 0.00% <0.00%> (ø)
src/connector/src/sink/mysql.rs 19.60% <0.00%> (-0.07%) ⬇️
src/connector/src/sink/redis.rs 0.00% <0.00%> (ø)
src/ctl/src/cmd_impl/bench.rs 0.00% <0.00%> (ø)
... and 147 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kwannoel kwannoel force-pushed the kwannoel/stub-sys-tables branch from e652b55 to 5a0131b Compare November 9, 2022 06:46
@kwannoel kwannoel force-pushed the kwannoel/stub-sys-tables branch from 5a0131b to 6ee7b34 Compare November 9, 2022 07:01
@kwannoel kwannoel changed the title feat(pg_catalog): stub system tables for sqlancer support feat(catalog): stub system tables for sqlancer support Nov 9, 2022
@kwannoel kwannoel marked this pull request as ready for review November 9, 2022 09:02
@kwannoel kwannoel requested review from yezizp2012 and lmatz November 9, 2022 09:11
@yezizp2012 yezizp2012 requested a review from HuaHuaY November 9, 2022 09:14
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 1201a10 into main Nov 9, 2022
@mergify mergify bot deleted the kwannoel/stub-sys-tables branch November 9, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants