-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pg_catalog): stub pg_opclass #6167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
force-pushed
the
kwannoel/pgopclass
branch
from
November 2, 2022 09:17
740e65c
to
c1edf7e
Compare
lmatz
approved these changes
Nov 2, 2022
yezizp2012
reviewed
Nov 2, 2022
kwannoel
force-pushed
the
kwannoel/pgopclass
branch
from
November 2, 2022 09:35
2a102d7
to
9d83d46
Compare
Codecov Report
@@ Coverage Diff @@
## main #6167 +/- ##
==========================================
- Coverage 74.65% 74.36% -0.30%
==========================================
Files 931 935 +4
Lines 149324 150096 +772
==========================================
+ Hits 111471 111612 +141
- Misses 37853 38484 +631
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yezizp2012
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
stub pg_opclass to support sqlancer.
Checklist
./risedev check
(or alias,./risedev c
)Update: More system tables needed, see: Tracking: Introduce Sqlancer #3364 (comment). Does not work for now.
Documentation
Types of user-facing changes
Note that although
pg_opclass
is user-facing. We do not want to expose it to end user. It is just introduced for sqlancer support.Release note
Refer to a related PR or issue link (optional)
#3431 (comment)