Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pg_catalog): stub pg_opclass #6167

Merged
merged 5 commits into from
Nov 2, 2022
Merged

feat(pg_catalog): stub pg_opclass #6167

merged 5 commits into from
Nov 2, 2022

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Nov 2, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

stub pg_opclass to support sqlancer.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • Try out sqlancer, it should work with this branch.
    Update: More system tables needed, see: Tracking: Introduce Sqlancer #3364 (comment). Does not work for now.

Documentation

Types of user-facing changes

Note that although pg_opclass is user-facing. We do not want to expose it to end user. It is just introduced for sqlancer support.

Release note

Refer to a related PR or issue link (optional)

#3431 (comment)

@kwannoel kwannoel marked this pull request as ready for review November 2, 2022 09:17
@kwannoel kwannoel requested a review from yezizp2012 November 2, 2022 09:35
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #6167 (d4c3712) into main (a878685) will decrease coverage by 0.29%.
The diff coverage is 32.27%.

@@            Coverage Diff             @@
##             main    #6167      +/-   ##
==========================================
- Coverage   74.65%   74.36%   -0.30%     
==========================================
  Files         931      935       +4     
  Lines      149324   150096     +772     
==========================================
+ Hits       111471   111612     +141     
- Misses      37853    38484     +631     
Flag Coverage Δ
rust 74.36% <32.27%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/catalog/internal_table.rs 100.00% <ø> (ø)
src/frontend/src/catalog/catalog_service.rs 5.42% <0.00%> (-0.36%) ⬇️
src/frontend/src/catalog/mod.rs 75.67% <ø> (ø)
src/frontend/src/catalog/view_catalog.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/create_view.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/drop_database.rs 80.51% <0.00%> (ø)
src/frontend/src/handler/drop_schema.rs 68.29% <0.00%> (ø)
src/frontend/src/handler/drop_view.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/handle_privilege.rs 78.60% <0.00%> (+1.43%) ⬆️
src/frontend/src/observer/observer_manager.rs 0.00% <0.00%> (ø)
... and 81 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 912db57 into main Nov 2, 2022
@mergify mergify bot deleted the kwannoel/pgopclass branch November 2, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants