Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add CH-benCHmark queries #5600

Merged
merged 24 commits into from
Oct 18, 2022
Merged

test: Add CH-benCHmark queries #5600

merged 24 commits into from
Oct 18, 2022

Conversation

nanderstabel
Copy link
Contributor

@nanderstabel nanderstabel commented Sep 28, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

To add more of the CH-benCHmark queries.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • In order to support more of the CH-benCHmark queries, this PR increases the number of records in the TPC-C dataset (as well as for the supplier table in TPC-H). Also some of the existing records were altered.
  • Extra transactions are added to the workload. In total now 10 Delivery transactions, 20 New Order transactions and 50 Payment transactions.
  • 15 new queries are supported and tested: q01, q02, q03, q04, q06, q09, q10, q11, q12, q15, q17, q18, q20, q21, q22,
  • tpcc_ prefix is removed.

Checklist

- [ ] I have written necessary rustdoc comments
- [ ] I have added necessary unit tests and integration tests

  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#5190

@github-actions github-actions bot added the component/test Test related issue. label Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #5600 (fa01299) into main (6d8c3c5) will increase coverage by 0.06%.
The diff coverage is 68.16%.

@@            Coverage Diff             @@
##             main    #5600      +/-   ##
==========================================
+ Coverage   74.85%   74.92%   +0.06%     
==========================================
  Files         922      923       +1     
  Lines      146824   146932     +108     
==========================================
+ Hits       109911   110093     +182     
+ Misses      36913    36839      -74     
Flag Coverage Δ
rust 74.92% <68.16%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/interval.rs 83.79% <0.00%> (-3.34%) ⬇️
src/common/src/types/mod.rs 64.58% <0.00%> (ø)
src/common/src/util/mod.rs 0.00% <ø> (ø)
src/expr/src/vector_op/cast.rs 84.29% <0.00%> (-2.20%) ⬇️
src/frontend/src/handler/util.rs 77.35% <0.00%> (-0.99%) ⬇️
src/stream/src/from_proto/agg_common.rs 0.00% <0.00%> (ø)
src/stream/src/from_proto/global_simple_agg.rs 0.00% <0.00%> (ø)
src/stream/src/from_proto/hash_agg.rs 0.00% <0.00%> (ø)
src/utils/pgwire/src/pg_field_descriptor.rs 63.54% <37.50%> (ø)
src/stream/src/executor/aggregation/minput.rs 64.15% <64.15%> (ø)
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nanderstabel nanderstabel marked this pull request as ready for review October 3, 2022 23:22
@nanderstabel nanderstabel marked this pull request as draft October 10, 2022 18:56
@nanderstabel nanderstabel marked this pull request as ready for review October 11, 2022 01:33
@lmatz lmatz self-requested a review October 11, 2022 01:57
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit f4e4475 into main Oct 18, 2022
@mergify mergify bot deleted the ns/ch-benchmark-queries branch October 18, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants