-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(streaming): introduce cache policy for hash join #3983
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3983 +/- ##
==========================================
- Coverage 73.88% 73.88% -0.01%
==========================================
Files 828 828
Lines 117044 117143 +99
==========================================
+ Hits 86481 86551 +70
- Misses 30563 30592 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…che_policy_for_hash_join
|
Preliminary benching (tpch q12) shows both policy produced similar result. However we are currently facing a compactor OOM issue that causes performance deterioration within 5 min. I will bench it later after #3921 solved. |
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
Close due to outdated and controversies. |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Previously our hash join executor only populate cache on reading a join key. Now we allow users to specify whether to populate cache on read or on both read an write.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
To populate cache on read (default setting) use the following statement:
To read cache on both read and write use the following statement:
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)