-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: introduce rpc error #3211
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LSTM.
Codecov Report
@@ Coverage Diff @@
## main #3211 +/- ##
==========================================
+ Coverage 73.56% 73.57% +0.01%
==========================================
Files 745 746 +1
Lines 102223 102191 -32
==========================================
- Hits 75199 75190 -9
+ Misses 27024 27001 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
What's changed and what's your intention?
As title.
We should always use the wrapper functions in
rpc_client
crate in the future. We may store some info about the worker nodes there and refine the error messages.Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)