Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable clippy await_holding_lock #288

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Feb 14, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #288 (022682b) into main (c0cb242) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #288      +/-   ##
============================================
- Coverage     74.08%   74.07%   -0.01%     
  Complexity     2665     2665              
============================================
  Files           850      850              
  Lines         48094    48098       +4     
  Branches       1584     1584              
============================================
- Hits          35629    35628       -1     
- Misses        11655    11660       +5     
  Partials        810      810              
Flag Coverage Δ
java 61.94% <ø> (ø)
rust 79.33% <85.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/connector/src/lib.rs 100.00% <ø> (ø)
rust/source/src/lib.rs 75.00% <ø> (ø)
rust/storage/src/lib.rs 100.00% <ø> (ø)
rust/stream/src/task/stream_manager.rs 51.82% <85.71%> (-0.51%) ⬇️
rust/common/src/types/ordered_float.rs 25.49% <0.00%> (-0.34%) ⬇️
rust/stream/src/executor/barrier_align.rs 78.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0cb242...022682b. Read the comment docs.

@skyzh skyzh enabled auto-merge (squash) February 14, 2022 06:30
@TennyZhuang TennyZhuang disabled auto-merge February 14, 2022 06:56
@TennyZhuang TennyZhuang enabled auto-merge (squash) February 14, 2022 06:56
@skyzh skyzh disabled auto-merge February 14, 2022 07:48
@skyzh skyzh enabled auto-merge (squash) February 14, 2022 07:48
@skyzh skyzh requested a review from fuyufjh February 14, 2022 07:48
@skyzh skyzh merged commit f436bd7 into main Feb 14, 2022
@skyzh skyzh deleted the skyzh/avoid-lock-boundary branch February 14, 2022 07:49
@skyzh
Copy link
Contributor Author

skyzh commented Feb 14, 2022

Also waiting for rust-lang/rust-clippy#8419 as we are using parking_lot mutex in our system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants