Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable source e2e tests temporarily #287

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Feb 14, 2022

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/fix Bug fix label Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #287 (3812e6b) into main (08fe034) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #287      +/-   ##
============================================
- Coverage     74.09%   74.08%   -0.02%     
  Complexity     2665     2665              
============================================
  Files           850      850              
  Lines         48088    48094       +6     
  Branches       1584     1584              
============================================
- Hits          35630    35629       -1     
- Misses        11648    11655       +7     
  Partials        810      810              
Flag Coverage Δ
java 61.94% <ø> (ø)
rust 79.34% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/frontend/src/optimizer/property/order.rs 62.50% <0.00%> (-3.29%) ⬇️
...rontend/src/optimizer/plan_node/batch_hash_join.rs 31.81% <0.00%> (-3.19%) ⬇️
...st/frontend/src/optimizer/property/distribution.rs 60.46% <0.00%> (-0.90%) ⬇️
rust/frontend/src/scheduler/plan_fragmenter.rs 97.91% <0.00%> (ø)
...ust/frontend/src/optimizer/plan_node/batch_sort.rs 0.00% <0.00%> (ø)
...ontend/src/optimizer/plan_node/stream_hash_join.rs 0.00% <0.00%> (ø)
...d/src/optimizer/plan_node/batch_sort_merge_join.rs 0.00% <0.00%> (ø)
...frontend/src/optimizer/plan_node/plan_tree_node.rs 10.71% <0.00%> (+0.18%) ⬆️
...frontend/src/optimizer/plan_node/batch_exchange.rs 66.66% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fe034...3812e6b. Read the comment docs.

@fuyufjh fuyufjh force-pushed the eric/fix-source-ci-fail branch from 9c2779c to afeb984 Compare February 14, 2022 07:01
@fuyufjh fuyufjh changed the title fix: increase sleep time of kafka source test fix: disable source e2e tests temporarily Feb 14, 2022
@fuyufjh fuyufjh marked this pull request as ready for review February 14, 2022 07:16
@fuyufjh fuyufjh requested a review from skyzh February 14, 2022 07:17
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a tracking issue for re-enable tests, otherwise it will be easily forgotten :(

@skyzh skyzh enabled auto-merge (squash) February 14, 2022 07:18
@skyzh skyzh merged commit c0cb242 into main Feb 14, 2022
@skyzh skyzh deleted the eric/fix-source-ci-fail branch February 14, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants