Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): use dyn for connection #20253

Merged
merged 1 commit into from
Jan 22, 2025
Merged

refactor(connector): use dyn for connection #20253

merged 1 commit into from
Jan 22, 2025
+22 −85

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 22, 2025

use less macros, similar to #20098

Signed-off-by: xxchan xxchan22f@gmail.com

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan
refactor(connector): use dyn for connection
2db8e12 
use less macros, similar to #20098

Signed-off-by: xxchan <xxchan22f@gmail.com>
tabVersion
tabVersion approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the refactor

@xxchan xxchan added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit f5aed12 Jan 22, 2025
29 of 30 checks passed
@xxchan xxchan deleted the xxchan/molecular-leopon branch January 22, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabVersion tabVersion tabVersion approved these changes

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

Assignees
No one assigned
Labels
type/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxchan @tabVersion