Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use 1 for vnode count of singletons for backward compatibility #18753

Draft
wants to merge 1 commit into
base: bz/var-vnode-table-catalog-vnode-count
Choose a base branch
from

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This is a progress towards #15900.

Try to address #18515 (comment), i.e., use 1 for vnode count of singletons when it comes to backward compatibility.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

BugenZhao commented Sep 29, 2024

@BugenZhao
Copy link
Member Author

This reveals a severe bug that we persist and notify about the internal tables before the vnode counts are correctly resolved, leading to inconsistency between the stream nodes and the catalog.

@BugenZhao
Copy link
Member Author

BugenZhao commented Sep 29, 2024

This reveals a severe bug

Will first fix in #18759

@BugenZhao BugenZhao changed the base branch from bz/var-vnode-system-tables to bz/var-vnode-table-catalog-vnode-count September 29, 2024 09:38
@BugenZhao BugenZhao force-pushed the bz/var-vnode-table-catalog-vnode-count branch from eb7d2cf to beba88d Compare September 30, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant