chore(agg): rename PbAggKind to PbAggType

[stdrc]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Just a preparation for fixing UDAF as window function. #18436

The rationale is that I'll introduce a new proto message called AggKind which contains both agg_type and agg metadata like UDF meta or wrapped scalar expression node.

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[stdrc]

• fix(agg): fix embedded UDAF as window function #18632
• chore(agg): rename PbAggKind to PbAggType #18631 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite

[BugenZhao]

ew proto message called AggKind which contains both agg_type and agg metadata like UDF meta or wrapped scalar expression node

Personally I prefer the opposite 🤣, i.e., Type composed of Kind (discriminant) and other fields.

[kwannoel]

Where is the renaming done? I could not find it.

In terms of the semantics LGTM. That's because kind is more generic than type.

[stdrc]

superseded by #18640