feat: variable vnode count support in table distribution #18373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
changed the title
BugenZhao
changed the title
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
4 tasks
fuyufjh
approved these changes
Sep 4, 2024
| use crate::hash::VirtualNode; | ||
| use crate::row::Row; | ||
| use crate::util::iter_util::ZipEqFast; | ||
|
|
||
| /// For tables without distribution (singleton), the `DEFAULT_VNODE` is encoded. | ||
| pub const DEFAULT_VNODE: VirtualNode = VirtualNode::ZERO; | ||
| pub use DEFAULT_VNODE as SINGLETON_VNODE; | ||
|
|
||
| use super::VnodeBitmapExt; | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| enum ComputeVnode { |
There was a problem hiding this comment.
May just rename it to TableDistribution, because the TableDistribution only wraps compute_vnode now.
There was a problem hiding this comment.
Not sure whether we could introduce more common fields in the future. Up to @wenym1 to decide.
4 tasks
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This is a progress towards #15900.
Specifically in the upcoming PRs, we aim to decrease the direct references on
VirtualNode::COUNTwithin the codebase. The total vnode count will be provided as a parameter in the refactored functions, although it will remain hardcoded asVirtualNode::COUNTat the call-site. Eventually, it will be made user-facing.This PR refactors the
TableDistribution. Logic changes are:Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.