fix: check split assignment before pushing mutation #18134
Conversation
Signed-off-by: tabVersion <tabvision@bupt.icu>
| @@ -588,6 +588,32 @@ where | |||
| ) | |||
| } | |||
|
|
|||
| pub fn validate_assignment(assignment: &mut HashMap<ActorId, Vec<SplitImpl>>) { | |||
There was a problem hiding this comment.
Please revert after resolving the doubled assignment issue.
As it's just an in-memory validation, I think it's totally okay to keep it here.
|
|
||
| for (split_id, actor_ids) in &mut split_to_actor { | ||
| if actor_ids.len() > 1 { | ||
| tracing::warn!(split_id = ?split_id, actor_ids = ?actor_ids, "split is assigned to multiple actors"); |
There was a problem hiding this comment.
I tend to panic here to expose the problem early. Otherwise, it will almost certainly trigger a panic in storage side, right?
There was a problem hiding this comment.
We don't know the root cause and have no way to fix the persisted data. From the frequency the users meet the problem, letting it panic and telling users to drop all sources can hurt the users' experience.
There was a problem hiding this comment.
Otherwise, it will almost certainly trigger a panic in storage side, right?
Oh, the following code will fix the multiple assignment issue and the compactor will no longer panic.
There was a problem hiding this comment.
Otherwise, it will almost certainly trigger a panic in storage side, right?
Oh, the following code will fix the multiple assignment issue and the compactor will no longer panic.
I see your point
tabVersion
added
need-cherry-pick-release-1.10
Signed-off-by: tabVersion <tabvision@bupt.icu>
Signed-off-by: tabVersion <tabvision@bupt.icu>
Signed-off-by: tabVersion <tabvision@bupt.icu>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Background: #16235
The pr increases overhead when pushing down mutation. Please revert after resolving the doubled assignment issue.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.