Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source): make s3 source compatible with minio #16521

Merged
merged 2 commits into from
May 7, 2024
Merged

fix(source): make s3 source compatible with minio #16521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a396cc2
update backon
wcy-fdu Apr 28, 2024
cff4a3b
fix
wcy-fdu Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions src/connector/src/source/filesystem/opendal_source/s3_source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ impl<Src: OpendalSource> OpendalEnumerator<Src> {
);
}

builder.enable_virtual_host_style();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry-pick it into release-1.9 because some users using the S3 bucket name with dot . and will meet error here https://github.com/apache/opendal/blame/ac694375da955ea6d3461aee0bfafd5a5d774541/core/src/services/s3/backend.rs#L600-L614


if let Some(assume_role) = assume_role {
builder.role_arn(&assume_role);
}
Expand Down
Loading