fix(source): make s3 source compatible with minio #16521
Merged
Task list completed / task-list-completed
Started
2024-05-20 16:28:52
ago
0 / 8 tasks completed
8 tasks still to be completed
Details
Required Tasks
| Task | Status |
|---|---|
remove enable_virtual_host_style so that both virtual_path_style: s3.endpoint_url = 'http://127.0.0.1:9301' and force_path_style: s3.endpoint_url = 'http://<bucket>.127.0.0.1:9301' can work well with minio. (Before this pr neither method works for minio. ) |
Incomplete |
| Summarize your change (mandatory) | Incomplete |
| How does this PR work? Need a brief introduction for the changed logic (optional) | Incomplete |
| Describe clearly one logical change and avoid lazy messages (optional) | Incomplete |
| Describe any limitations of the current code (optional) | Incomplete |
| Refer to a related PR or issue link (optional) | Incomplete |
| I have written necessary rustdoc comments | Incomplete |
| I have added necessary unit tests and integration tests | Incomplete |
| I have added test labels as necessary. See details. | Incomplete |
| I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). | Incomplete |
| My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). | Incomplete |
All checks passed in ./risedev check (or alias, ./risedev c) |
Incomplete |
| My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) | Incomplete |
| My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) | Incomplete |
Loading