feat(meta): show recovery cause when request is rejected #13836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
When a DDL request is sent to the meta service which is under failure recovery, the failure cause will be included in the error message as well. Thanks to the progress made on #11443, all we need to do is to correctly return the error in meta.
It's worth noting that after #12999, the message will rarely be seen by users as
DROP
is not rejected. But I guess it's still a good-to-have.Also I don't find a way to test it in CI, as we cannot manually trigger a failure recovery now (or we have to depend on some unresolved bugs 😄, like the examples above). Perhaps we can introduce a debug-only statement to manually trigger one.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.