Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(risedev): refine error reporting #13455

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Nov 16, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Disable backtrace for risedev-dev itself to make it more user-friendly.
  • Provide more error context if possible.
  • Minor refactor to wait_http to reduce duplication.
  • Avoid repeating the error after main returns.
image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (04aca78) 67.76% compared to head (968a2b8) 67.82%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/risedevtool/src/task.rs 0.00% 27 Missing ⚠️
src/risedevtool/src/bin/risedev-dev.rs 0.00% 11 Missing ⚠️
src/risedevtool/src/wait.rs 0.00% 10 Missing ⚠️
src/risedevtool/src/task/task_kafka_ready_check.rs 0.00% 2 Missing ⚠️
src/risedevtool/src/task/task_etcd_ready_check.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13455      +/-   ##
==========================================
+ Coverage   67.76%   67.82%   +0.06%     
==========================================
  Files        1528     1528              
  Lines      260887   260897      +10     
==========================================
+ Hits       176779   176946     +167     
+ Misses      84108    83951     -157     
Flag Coverage Δ
rust 67.82% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BugenZhao BugenZhao added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit 8bcae11 Nov 16, 2023
@BugenZhao BugenZhao deleted the bz/risedev-error-report branch November 16, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants