-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: except after qualified wildcard #10723
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10723 +/- ##
==========================================
- Coverage 69.94% 69.94% -0.01%
==========================================
Files 1312 1312
Lines 224605 224668 +63
==========================================
+ Hits 157090 157133 +43
- Misses 67515 67535 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @st1page Please take another look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add support for except after qualified wildcard. Example:
Also move the
select except
related test to single file.There is one more question: do we need to support except with ambiguous columns? The related results varies from implementations. Consider
duckdb outputs
and clickhouse outputs
Close: #10711
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note