-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using integration test instead of unit test #9878
Comments
I've tried this change in BTW, I didn't changed any visibility, so I think this claim is true:
About compilation speedChanging one line in The former (UTs) are slower to compile because you need to compile the whole Another factor is that if you 1. |
We might be able to simplify executor creation which is also painful (not sure). (Note that #9787 simplified deriving outputs in the tests, without changing executor creation). |
This also applies to other packages especially those compile slowly. 😇 Although I'm not sure about the frequency of adding new tests. Anyway if you feel painful about that you may consider writing new tests in
|
Close as no futher action planned. This issue can be used as a reference later. |
So that we can avoid them being compiled twice when running unit tests. No tests are ignored after the change (still 1575 tests, but 84 binaries -> 67 binaries) Note: there aren't significant improvements, because the bottleneck is not improved. ref: #9878 (comment)
Originally posted by @st1page in #9787 (comment)
The text was updated successfully, but these errors were encountered: