Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SASL/GSSAPI and SASL/OAUTHBEARER back to doc #2160

Merged
merged 3 commits into from
May 11, 2024

Conversation

WanYixian
Copy link
Contributor

@WanYixian WanYixian commented May 10, 2024

Info

For reviewers

  • Preview

  • Key points

    • [ Parts that may need revision or extra consideration. ]

Before merging

  • I have checked the doc site preview, and the updated parts look good.

  • I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (CharlieSYH, emile-00, & hengm3467).

@WanYixian WanYixian linked an issue May 10, 2024 that may be closed by this pull request
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2160.d2fbku9n2b6wde.amplifyapp.com

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion
Copy link
Contributor

I'd prefer adding AWS_MSK_IAM together with GSSAPI and OAUTHBEARER.
related: risingwavelabs/risingwave#16625

@WanYixian
Copy link
Contributor Author

I'd prefer adding AWS_MSK_IAM together with GSSAPI and OAUTHBEARER. related: risingwavelabs/risingwave#16625

Thanks! Will use another PR to track #2158 it. So merge this PR for now.

@WanYixian WanYixian merged commit 95beea5 into main May 11, 2024
3 checks passed
@WanYixian WanYixian deleted the 2151-missing-docs-for-kafka-sourcesink-+-kerberos branch May 11, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing docs for Kafka source/sink + kerberos
3 participants