Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe behavior ext. for SFENCE.VMA and HFENCE.VMA #84

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Conversation

rsahita
Copy link
Collaborator

@rsahita rsahita commented Oct 1, 2024

addresses issue #77

Signed-off-by: Ravi Sahita <ravi@rivosinc.com>
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
Co-authored-by: Samuel Holland <samuel.holland@sifive.com>
Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
chapter3.adoc Outdated Show resolved Hide resolved
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
Signed-off-by: Ravi Sahita <ravi@rivosinc.com>
chapter3.adoc Outdated Show resolved Hide resolved
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
Copy link
Collaborator

@SiFiveHolland SiFiveHolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two more places where Sinval should be Svinval

chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
Co-authored-by: Samuel Holland <samuel.holland@sifive.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
Copy link
Collaborator

@ved-rivos ved-rivos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The description turned out to be bit more wordy than needed.

@rsahita
Copy link
Collaborator Author

rsahita commented Oct 8, 2024

LGTM. The description turned out to be bit more wordy than needed.

yeah can reduce it in the arc review stage.

@rsahita rsahita merged commit f7d60c0 into main Oct 8, 2024
1 check passed
@rsahita rsahita deleted the issue/77 branch October 8, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants