Update description of mtval2 in CSR table #1643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ved-rivos
reviewed
Sep 19, 2024
While it is always a guest physical address for the hypervisor traps, when used by a double trap it holds an mcause value. Change the description to "second trap value" to match the description used in the section heading. While touching this line also sync the description of the other CSRs in this part of the table. Signed-off-by: Alex Richardson <alexrichardson@google.com>
arichardson
force-pushed
the
patch-1
branch
from
57289f6
to
7c497a9
Compare
|
I think we can also fix up |
|
Agreed with both of @ved-rivos's comments. Ping me when it's time to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is always a guest physical address for the hypervisor
traps, when used by a double trap it holds an mcause value.
Change the description to "second trap value" to match the description
used in the section heading. While touching this line also sync the
description of the other CSRs in this part of the table.