Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update B extension description to remove mention of sub extensions grouped for review #1419

Merged
merged 1 commit into from
May 22, 2024
Merged

Update B extension description to remove mention of sub extensions grouped for review #1419

merged 1 commit into from
May 22, 2024

Conversation

jordancarlin
Copy link
Contributor

  • Remove heading stating "Bit-manipulation a, b, c and s extensions grouped for public review and ratification"
  • Slightly reword intro to remove mention of lack of a larger extension now that B is ratified

@jordancarlin jordancarlin force-pushed the patch-1 branch 2 times, most recently from 16880ea to d5ff5cc Compare May 22, 2024 01:43
aswaterman
aswaterman requested changes May 22, 2024
View reviewed changes
src/b-st-ext.adoc Outdated Show resolved Hide resolved
@jordancarlin
Update B extension description to remove mention of sub extensions gr…
b68d92d 
…ouped for review

Signed-off-by: Jordan Carlin <jordanmcarlin@gmail.com>
aswaterman
aswaterman approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Works for me.

Overall, there are several rough edges associated with integrating these specs into a single document. The intro to this chapter is probably due for a total rewrite, but improvements like this are a useful step.

@aswaterman aswaterman merged commit 22d2691 into riscv:main May 22, 2024
1 of 2 checks passed
@jordancarlin jordancarlin deleted the patch-1 branch May 22, 2024 15:31
ved-rivos pushed a commit to ved-rivos/riscv-isa-manual that referenced this pull request Jul 3, 2024
@jordancarlin @ved-rivos
Update B extension description to remove mention of sub extensions gr…
63fa143 
…ouped for review (riscv#1419)

Signed-off-by: Jordan Carlin <jordanmcarlin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordancarlin @aswaterman